On 25.02.25 19:38, Christopher Obbard wrote: > Hi Jan, > > On Tue, 25 Feb 2025 at 18:21, Jan Kiszka <jan.kis...@siemens.com> wrote: >> >> On 25.02.25 19:16, Christopher Obbard wrote: >>> Hi Jan, >>> >>> On Tue, 25 Feb 2025 at 18:11, Jan Kiszka <jan.kis...@siemens.com> wrote: >>>> >>>> On 25.02.25 19:02, Christopher Obbard wrote: >>>>> For some builds, e.g. inside a minimal buildroot image, we may not want >>>>> the >>>>> tests to be built. Add an option --disable-tests to configure to disable >>>>> building the tests. >>>> >>>> Now playing with it again: tests are only build if explicitly requested >>>> (make check), not via plain "make". What exactly is the problem you are >>>> facing in that case? >>> >>> Thanks for that hint. Hmm, I am building efibootguard with buildroot >>> using the autoconf built-in abstraction (not entirely sure what >>> commands it is calling under the hood), which builds the tests >>> (linking to check and lots of other things). >>> When building the host tools, building the tests causes some >>> additional dependencies. So I am disabling the building of the tests >>> to workaround needing to package more things in buildroot. >>> >>> I guess I need to check if/how buildroot is calling "make check" in my >>> efibootguard package. Again: buildroot is something I don't know well >>> enough, but know enough to cause trouble ;-). >> >> buildroot is just many makefiles and a little bit of kconfig ;). >> >> Should be possible to figure out the exact rule it calls for building >> (verbose mode?), and maybe you only need to tell it to not run package >> tests? But if here is something in addition that causes the tests to be >> built, we can still merge this here. I just want to understand the >> reason better. > > I had a quick look at `host-autotools-package` in buildroot, and ran > my package build with `make V=1` it doesn't appear to call `make > check`. > So I guess my patch is still valid or there's something else wrong ?
$ make ... Making all in tools/tests make[2]: Nothing to be done for 'all'. Or are you already failing during configure, due to missing libcheck? But that is something your patch is not even addressing. Jan -- Siemens AG, Foundational Technologies Linux Expert Center -- You received this message because you are subscribed to the Google Groups "EFI Boot Guard" group. To unsubscribe from this group and stop receiving emails from it, send an email to efibootguard-dev+unsubscr...@googlegroups.com. To view this discussion visit https://groups.google.com/d/msgid/efibootguard-dev/2021c367-5aa3-487f-822b-3ed3d0a4d547%40siemens.com.
