Re: Performance improvement of Download Code

[Anshul Dutta, Noida]

One bottleneck to performance is read operation from the hard disk. I would suggest you to read the data from the file in the init method, put it in an instance variable and read it from there for all the requests. -----Original Message----- From: Dmitri Colebatch [mailto:[EMAIL PROTECTED]] Sent: Thursday, November 14, 2002 11:06 AM To: [EMAIL PROTECTED] Subject: Re: Performance improvement of Download Code I have no idea what the performance implications of this are, but if all you're doing is downloading the file, I wouldn't bother with BufferedInputStream.... why not just just FileInputStream as is....   alternatively, depending on your app server, you could make put the "download" directory under WEB-INF/downloads or something, and just redirect to that....  but some app servers dont like this despite its legitimacy being clarified in the 2.3 spec.   hth dim ----- Original Message ----- From: ssmtech To: [EMAIL PROTECTED] Sent: Thursday, November 14, 2002 4:30 PM Subject: Performance improvement of Download Code Hello Sir,              I am working on J2EE application Server and on EJB and trying to Download a "Text File" from our application server..              I am using the Following code for downloading,but the thing is that,no doubt it downloads the Text file properly,it takes              a LONG time to do so....     <code>   public HttpServletResponse doDownloadFile(HttpServletRequest req,HttpServletResponse res)   throws ServletException,IOException {         ServletOutputStream stream = null;      res.setContentType("application/binary");       String fname1 = req.getParameter("BusinessId");    String fname2 = req.getParameter("AccountUserId");    String fname =fname1+"-"+fname2+".txt";    res.setHeader("Content-Disposition","inline; filename=\""+fname+"\";");      BufferedInputStream bif = null;      try {         bif = new BufferedInputStream(new FileInputStream("E:/abcd/download/xyz/"+fname));        stream = res.getOutputStream();     int data;     while(( data = "bif.read())" != -1) {           stream.write(data);     stream.flush();         }     bif.close();    stream.close();       return res;    } catch(Exception e) {     System.out.println("The Exception is :"+e);    }       finally {    if (stream != null)    stream.close();    return res;    }     }//end of method   </Code>       Can anybody tell me how do i improve the Performance of the Code,or something is wrong with the code...     Any suggestions or code snippets will be greatly appreciated...   Thanks a million is advance. Regards Sam