Great! Note however that replacing #ifdef HAVE_CELT_0_5_0_OR_LATER with #ifdef HAVE_CELT_0_7_0_OR_LATER is not good.
There should be something like this: #ifdef HAVE_CELT_0_7_0_OR_LATER your new line #elifdef HAVE_CELT_0_5_0_OR_0_6_0 existing line #else existing line #endif Could you do the correct #define checking in celtcodec.c and modifying configure.ac for the new version too (replacing 050orlater with 050or060 and adding a similar text to 0.5 version)? Eugen e schmidbauer wrote: > This should work. > > On Sun, Jan 31, 2010 at 2:48 PM, Eugen Dedu <[email protected] >> wrote: > >> I have two warnings: >> snoopy:~/softs/ekiga/opal/plugins/audio/celt$ make >> [CC] celtcodec.c >> celtcodec.c: In function ‘valid_for_sip’: >> celtcodec.c:196: warning: pointer targets in passing argument 1 of >> ‘strcasecmp’ differ in signedness >> /usr/include/string.h:534: note: expected ‘const char *’ but argument is >> of type ‘const unsigned char *’ >> celtcodec.c: At top level: >> celtcodec.c:202: warning: initialization from incompatible pointer type >> [LD] ./celtcodec_pwplugin.so >> >> I removed the first one by removing "unsigned". Do you know how to fix >> the 2nd warning? >> >> e schmidbauer wrote: >>> Please try compiling with this file. I have not been able to test this >>> version of celt because i do not have a linux machine available to cross >>> compile. If you are successful at compiling, i can test it out. I will >> get >>> to the plugins/configure.ac file later. Please tell me if you get any >> errors >>> or warnings. Thank you. >>> >>> On Sun, Jan 31, 2010 at 8:15 AM, Eugen Dedu < >> [email protected] >>>> wrote: >>>> e schmidbauer wrote: >>>>> I've attached what i think will work for compiling opal with celt 0.7 >>>>> Can you please test it to see if it compiles? >>>> Thanks a lot for the patch. >>>> >>>> 1. When compiling, I have a few warnings, could you remove them too? >>>> >>>> snoopy:~/softs/ekiga/opal/plugins/audio/celt$ make >>>> [CC] celtcodec.c >>>> celtcodec.c: In function ‘celt_codec_encoder’: >>>> celtcodec.c:146: warning: pointer targets in passing argument 4 of >>>> ‘celt_encode’ differ in signedness >>>> /usr/include/celt/celt.h:214: note: expected ‘unsigned char *’ but >>>> argument is of type ‘char *’ >>>> celtcodec.c: In function ‘celt_codec_decoder’: >>>> celtcodec.c:176: warning: pointer targets in passing argument 2 of >>>> ‘celt_decode’ differ in signedness >>>> /usr/include/celt/celt.h:262: note: expected ‘const unsigned char *’ but >>>> argument is of type ‘char *’ >>>> [LD] ./celtcodec_pwplugin.so >>>> >>>> 2. Also, have you successfully made a communication with celt (0.7) >>>> using your file? >>>> >>>> 3. Do you have the will to modify also plugins/configure.ac so that it >>>> defines HAVE_CELT_0_7_0 and use that #define in celtcodec.c so that it >>>> compiles with previous versions of celt too? If not, I will send your >>>> patch to be committed anyway, but it is better with it... >>>> >>>> Thanks, >>>> -- >>>> Eugen >>>> _______________________________________________ >>>> Ekiga-devel-list mailing list >>>> [email protected] >>>> http://mail.gnome.org/mailman/listinfo/ekiga-devel-list >>>> >>> >>> ------------------------------------------------------------------------ >>> >>> _______________________________________________ >>> Ekiga-devel-list mailing list >>> [email protected] >>> http://mail.gnome.org/mailman/listinfo/ekiga-devel-list >> _______________________________________________ >> Ekiga-devel-list mailing list >> [email protected] >> http://mail.gnome.org/mailman/listinfo/ekiga-devel-list >> > > > ------------------------------------------------------------------------ > > _______________________________________________ > Ekiga-devel-list mailing list > [email protected] > http://mail.gnome.org/mailman/listinfo/ekiga-devel-list _______________________________________________ Ekiga-devel-list mailing list [email protected] http://mail.gnome.org/mailman/listinfo/ekiga-devel-list
