I'm glad I was able to steer you in the right direction. I flubbed a PR recently since I have not used git consistently in the past few years, so I am glad someone else can learn from my mistakes. Your PR seemed to have gained some attention! :)
Ivan On Tue, Feb 11, 2014 at 1:17 PM, InquiringMind <[email protected]>wrote: > Ivan, > > Thanks so much for the advice. I created the nm-branch (nautical miles > branch) off of master, then cloned it to my laptop. Found the two files > (DistanceUnit, and DistanceUnitTests). Made the (very simple) changes. Then > built ES and ran only the tests in DistanceUnitTests. The build was > surprisingly quick; the tests ran and succeeded: > > $ mvn test -Dtests.class=org.elasticsearch.common.unit.DistanceUnitTests > <snip> > [INFO] Your default console's encoding may not display certain unicode > glyphs: MacRoman > Executing 1 suite with 1 JVM. > > Started J0 PID(9572@<redacted>). > Suite: org.elasticsearch.common.unit.DistanceUnitTests > Completed in 0.54s, 2 tests > > [INFO] JVM J0: 0.44 .. 1.56 = 1.12s > [INFO] Execution time total: 1.57 sec. > [INFO] Tests summary: 1 suite, 2 tests > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 8.507s > [INFO] Finished at: Tue Feb 11 15:57:37 EST 2014 > [INFO] Final Memory: 10M/123M > [INFO] > ------------------------------------------------------------------------ > > Here is the pull request: > https://github.com/elasticsearch/elasticsearch/pull/5088 > > Please let me know if anything is amiss. This is my first actual use of > GitHub. A local git expert offered his advice as well, but any errors are > mine and no one else's. > > Brian > > -- > You received this message because you are subscribed to the Google Groups > "elasticsearch" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/elasticsearch/1ed828ce-77e6-46cc-851b-90c0b27d05bb%40googlegroups.com > . > > For more options, visit https://groups.google.com/groups/opt_out. > -- You received this message because you are subscribed to the Google Groups "elasticsearch" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/elasticsearch/CALY%3DcQCaCWYy0EUmEFk3GwKf48CM5QVL_Ska-K_TdeUTx-WZNw%40mail.gmail.com. For more options, visit https://groups.google.com/groups/opt_out.
