Hi, A lot of places in ES are now catching Throwable. There are several commits that have changed from catching Exception to catching Throwable. For instance, TransportClientNodesService catches Throwable, ignores it and retries the operation [1]. Some places it logs it as debug and continues.
Throwable includes OutOfMemoryError, StackOveflowError, LinkageError and so on. These are usually unrecoverable problems, so catching Throwable is usually not considered a good practice. I think this looks very odd. Is this intentional? Are you really sure you want to continue when you get those errors thrown, no matter what? "An Error is a subclass of Throwable that indicates serious problems that a reasonable application should not try to catch." - Henrik [1] https://github.com/elasticsearch/elasticsearch/blob/master/src/main/java/org/elasticsearch/client/transport/TransportClientNodesService.java#L267 -- You received this message because you are subscribed to the Google Groups "elasticsearch" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/elasticsearch/47ea9472-0606-4107-bc9c-a2dcd85c8d29%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
