I agree with what Cody said. Coding style is something that can be fixed, and in the end it means the same to the compiler, so if whatever the branch implements fits into the projects' goals, you should only review it as "Needs Fixing".
Dissaproving a branch is equivalent to telling its developer that he shouldn't care about working on it anymore, since it will never get into trunk. On vie, sep 7, 2012 at 9:27 , Cody Garver <[email protected]> wrote: I think "Disapprove" should be for when you don't like the code as a whole or its concept or idea. Or the change entirely. And "Needs Fixing" should be for when you don't like a particular part of the code but it is actually attempting to fix a bug or make a desired change. What does everyone else think? On Fri, Sep 7, 2012 at 10:24 AM, David Gomes <[email protected]> wrote: I'm very strict about the Coding Style, and what should I mark a branch that I disapprove of because of its coding style - "Disapprove" or "Needs fixing"? We should all be using the same thing, hence the question, thanks! David (Munchor) -- Mailing list: https://launchpad.net/~elementary-dev-community Post to : [email protected] Unsubscribe : https://launchpad.net/~elementary-dev-community More help : https://help.launchpad.net/ListHelp -- Cody Garver
-- Mailing list: https://launchpad.net/~elementary-dev-community Post to : [email protected] Unsubscribe : https://launchpad.net/~elementary-dev-community More help : https://help.launchpad.net/ListHelp
