Hi Victor! Yes, it works fine. You can merge it.
Thanks! El 23/03/13 20:29, Victor Eduardo escribió: > Hi Sergio, > > Thank you for the patch! > > I've applied it to a separate branch for testing purposes, and it has > worked well so far. You can find that branch here: > lp:~elementary-apps/+junk/cmake-modules-translations-patch<https://code.launchpad.net/~elementary-apps/+junk/cmake-modules-translations-patch> > > I have been testing the module during this week. I've also added a revision > that simplifies things a bit, and it works perfectly here. Could you please > test it and tell me if it works for you as well? I just want to make sure I > have not introduced any regressions. > > Anyway, I should be merging your changes soon. Thank you again for your > work. > > Regards, > Victor. > > > On Sun, Mar 17, 2013 at 6:58 AM, Sergio Costas <rasters...@gmail.com> wrote: > >> Ok, that explains why I was incapable of finding that option :) >> >> Anyway, I already sent the diff file to Victor. >> >> El 17/03/13 13:47, Raphael Isemann escribió: >>> You can't make a merge proposal to +junk branches AFAIK. >>> >>> - Teemperor >>> >>> 2013/3/17 Victor Eduardo <victoredua...@gmail.com>: >>>> Hi Sergio, >>>> >>>> Thank you for your time and work. >>>> >>>> You can find the most recent version of our CMake modules at >>>> lp:~elementary-apps/+junk/cmake-modules. >>>> >>>> It would be great if you could create a merge proposal for your >>>> modifications to Translations.cmake into the branch mentioned above. >> We'd >>>> review it as soon as possible. If you have no time for that, just let us >>>> know and we'll take care of manually merging the changes. >>>> >>>> Best Regards, >>>> Victor. >>>> >>>> >>>> >>>> On Sat, Mar 16, 2013 at 1:40 PM, Sergio Costas <rasters...@gmail.com> >> wrote: >>>>> Hi all: >>>>> >>>>> I'm working on a project to easily generate the CMake scripts for any >>>>> Vala project, and found that the CMake Vala scripts for >>>>> internationalization has two little bugs: >>>>> >>>>> * uses the C language for processing the vala source code, when the >> C# >>>>> would be better >>>>> * it doesn't check the glade's .ui files >>>>> >>>>> I modified the Translations.cmake file to support both things (and >> still >>>>> can search .c files too), but I'm not sure where should I upload the >>>>> diff. The github repo from Jakob Westhoff seems to be outdated compared >>>>> to the file available at http://ubuntuone.com/p/1F3R/ >>>>> >>>>> Thanks. >>>>> >>>>> -- >>>>> Nos leemos >>>>> RASTER (Linux user #228804) >>>>> ras...@rastersoft.com http://www.rastersoft.com >>>>> >>>>> >>>>> -- >>>>> Mailing list: https://launchpad.net/~elementary-dev-community >>>>> Post to : elementary-dev-community@lists.launchpad.net >>>>> Unsubscribe : https://launchpad.net/~elementary-dev-community >>>>> More help : https://help.launchpad.net/ListHelp >>>> >>>> -- >>>> Mailing list: https://launchpad.net/~elementary-dev-community >>>> Post to : elementary-dev-community@lists.launchpad.net >>>> Unsubscribe : https://launchpad.net/~elementary-dev-community >>>> More help : https://help.launchpad.net/ListHelp >>>> >> >> -- >> Nos leemos >> RASTER (Linux user #228804) >> ras...@rastersoft.com http://www.rastersoft.com >> >> >> -- >> Mailing list: https://launchpad.net/~elementary-dev-community >> Post to : elementary-dev-community@lists.launchpad.net >> Unsubscribe : https://launchpad.net/~elementary-dev-community >> More help : https://help.launchpad.net/ListHelp >> -- Nos leemos RASTER (Linux user #228804) ras...@rastersoft.com http://www.rastersoft.com -- Mailing list: https://launchpad.net/~elementary-dev-community Post to : elementary-dev-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~elementary-dev-community More help : https://help.launchpad.net/ListHelp
