1) is not my code, but I can definitely include that change. 2) This may be a granite deficiency, as the about option here works by relying on the Granite.Application's behavior when running with the --about option. I think that when Granite creates the about dialog when the app is already running, the Gtk setting has already been set (in PantheonTerminalWindow.vala), but when it creates the dialog without a running app, no such setting has been made, and it comes up light. I tried setting the dark theme before running the main app, but it did not work. I got this error message:
[_LOG_LEVEL_FATAL 16:24:08.038999] [GLib-GObject] g_object_set: assertion 'G_IS_OBJECT (object)' failed [_LOG_LEVEL_FATAL 16:24:08.039074] PantheonTerminal will not function properly. Perhaps a dark_theme value in Granite.Application is necessary? Or am I doing something wrong? I will try to investigate a little later. -- https://code.launchpad.net/~elementary-dev-community/pantheon-terminal/fix-1329550/+merge/229683 Your team elementary Developer Community is subscribed to branch lp:~elementary-dev-community/pantheon-terminal/fix-1329550. -- Mailing list: https://launchpad.net/~elementary-dev-community Post to : elementary-dev-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~elementary-dev-community More help : https://help.launchpad.net/ListHelp
