Public bug reported:

Currently, all of the setup logic happens in the constructor. This is
fine, but seems slightly awkward and also raises a warning that you're
not doing anything with the plug other than instantiating it. So I
propose:

1. Create the plug subclass
2. Instantiate
3. Call .register()

This keeps the most simplicity and ease of use possible while
eliminating the error.

** Affects: libpantheon
     Importance: Undecided
         Status: Confirmed

** Summary changed:

- Have a "register" function instead of putting connection logic into 
construcotr
+ Have a "register" function instead of putting connection logic into 
constructor

** Changed in: libpantheon
       Status: New => Confirmed

-- 
You received this bug notification because you are a member of
elementary desktop team, which is the registrant for Pantheon Library.
https://bugs.launchpad.net/bugs/821843

Title:
  Have a "register" function instead of putting connection logic into
  constructor

Status in Pantheon Library:
  Confirmed

Bug description:
  Currently, all of the setup logic happens in the constructor. This is
  fine, but seems slightly awkward and also raises a warning that you're
  not doing anything with the plug other than instantiating it. So I
  propose:

  1. Create the plug subclass
  2. Instantiate
  3. Call .register()

  This keeps the most simplicity and ease of use possible while
  eliminating the error.

To manage notifications about this bug go to:
https://bugs.launchpad.net/libpantheon/+bug/821843/+subscriptions

-- 
Mailing list: https://launchpad.net/~elementaryart
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~elementaryart
More help   : https://help.launchpad.net/ListHelp

Reply via email to