Review: Needs Fixing Could you split this into a merge request for lp:lightdm-webkit-greeter (the upstream project) and lp:~ubuntu-desktop/lightdm-webkit-greeter/ubuntu (the packaging).
Apart from that the changes are good, but please: - Remove commented out code - Remove any temporary debugging (note there is a debug line that will print users passwords to the log which is a big security issue) - Check whitespace (no tabs, four space indent). -- https://code.launchpad.net/~elementaryart/lightdm-webkit-greeter/fixes-ubuntu/+merge/75399 Your team elementary desktop team is subscribed to branch lp:~elementaryart/lightdm-webkit-greeter/fixes-ubuntu. -- Mailing list: https://launchpad.net/~elementaryart Post to : [email protected] Unsubscribe : https://launchpad.net/~elementaryart More help : https://help.launchpad.net/ListHelp
