Review: Approve Victor: You can still acess to the notebook with get_children() ;) When I'm saying it is pointless, what I mean is that it introduces a "bug": tab.get_parent won't return the dynamic notebook but the internal one, so, it can create a bug and brings more code complexity. But yeah, it is probably a problem (even if I think it could be handled to not crash, even if base gtknotebook methods are used). But, well, like I said to Tom on IRC, I don't have a lot of time, and I won't have a lot of time to look into this bug soon, so, let's ignore this (rather minor) parent bug for now, I will file a bug report, we'll fix it later. -- https://code.launchpad.net/~tombeckmann/granite/granite-dynamic-notebook-gkt-based/+merge/104050 Your team elementaryart (old) is subscribed to branch lp:granite.
-- Mailing list: https://launchpad.net/~elementaryart Post to : [email protected] Unsubscribe : https://launchpad.net/~elementaryart More help : https://help.launchpad.net/ListHelp
