Robert Roth has proposed merging lp:~evfool/marlin/fixforwardmenu into
lp:marlin.
Requested reviews:
The elementary Project (elementaryproject)
Related bugs:
Bug #789916 in Marlin: "forward menu creates an infinite loop"
https://bugs.launchpad.net/marlin/+bug/789916
For more details, see:
https://code.launchpad.net/~evfool/marlin/fixforwardmenu/+merge/66603
Fixed possible typo, as specifying a negative number for the forward steps to
take will make the forward stack try to pop too much, and after the last item
has been popped, it will go on, thus causing a crash. After removing the - from
the steps to take it seems to work as expected.
--
https://code.launchpad.net/~evfool/marlin/fixforwardmenu/+merge/66603
Your team The elementary Project is requested to review the proposed merge of
lp:~evfool/marlin/fixforwardmenu into lp:marlin.
=== modified file 'src/View/ViewContainer.vala'
--- src/View/ViewContainer.vala 2011-05-21 16:39:37 +0000
+++ src/View/ViewContainer.vala 2011-07-01 13:33:18 +0000
@@ -227,7 +227,7 @@
foreach(var path in list){
int cn = n++; // For explenation look up
var item = new MenuItem.with_label (path.replace("file://", "")); //TODO add `real' escaping/serializing
- item.activate.connect(() => forward(-cn));
+ item.activate.connect(() => forward(cn));
forward_menu.insert(item, -1);
}
_______________________________________________
Mailing list: https://launchpad.net/~elementaryweb
Post to : [email protected]
Unsubscribe : https://launchpad.net/~elementaryweb
More help : https://help.launchpad.net/ListHelp
