> +for what_arg in "--debug-syms" "--defined-only" "--dynamic" "--extern-only";
> do
> + for format_arg in "--format=bsd" "--format=sysv" "--format=posix"; do
> + for out_arg in "--numeric-sort" "--no-sort" "--reverse-sort"; do
Use '' instead of "" any place you can. Here there is really no need for
quoting at all.
Indent two spaces, not four.
> + for file in $self_test_files; do
> + testrun "$@" $file > /dev/null \
> + || { echo "*** failure in $@ $file"; exit_status=1; }
"$@" is special magic but $@ is just $* and it looks more normal
to use $* where you don't need "$@".
Indent two spaces, not four.
Otherwise looks fine modulo the typo in the commit topic line.
Thanks,
Roland
_______________________________________________
elfutils-devel mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/elfutils-devel
