On Tue, 2012-08-14 at 16:18 +0200, Mark Wielaard wrote: > - libelf/elf32_checksum.c: Seems fine since it just uses the raw > data to calculate the checksum. O, and it seems SECTION_STRIP_P > doesn't actually depend on ebl_debugscn_p anymore, despite the > /* The SECTION_STRIP_P macro wants to call into libebl which we cannot > do and do not have to do here. Provide a dummy replacement. */ > #define ebl_debugscn_p(ebl, name) true > We should probably remove that then while we are at it.
Double checked and done. commit 2105022c82697f6879ead5c8eee24d8fedac65b2 Author: Mark Wielaard <[email protected]> Date: Tue Aug 14 16:48:50 2012 +0200 elf32_checksum.c: Removed unused ebl_debugscn_p define and confusing comment. Signed-off-by: Mark Wielaard <[email protected]> diff --git a/libelf/ChangeLog b/libelf/ChangeLog index 18ada85..5ac70f5 100644 --- a/libelf/ChangeLog +++ b/libelf/ChangeLog @@ -1,3 +1,8 @@ +2012-08-14 Mark Wielaard <[email protected]> + + * elf32_checksum.c (ebl_debugscn_p): Removed unused define and + confusing outdated comment. + 2012-08-01 Petr Machata <[email protected]> * elf_getarsym (read_number_entries): New function. diff --git a/libelf/elf32_checksum.c b/libelf/elf32_checksum.c index 7c53b17..4c59856 100644 --- a/libelf/elf32_checksum.c +++ b/libelf/elf32_checksum.c @@ -46,11 +46,6 @@ #endif -/* The SECTION_STRIP_P macro wants to call into libebl which we cannot - do and do not have to do here. Provide a dummy replacement. */ -#define ebl_debugscn_p(ebl, name) true - - #define process_block(crc, data) \ __libelf_crc32 (crc, data->d_buf, data->d_size) _______________________________________________ elfutils-devel mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/elfutils-devel
