On Wed, 06 Nov 2013 11:44:14 +0100, Mark Wielaard wrote: > That looks fine. But please do add a comment in the regular > (non-portable) testcase with a hint that older systems might be broken > somewhere at the start. So people that run the tests on an older system > and happen to see this this fail know their system is broken and there > is a workaround on the portable branch.
Put there the attached comment. Jan
diff --git a/tests/backtrace.c b/tests/backtrace.c index 36995bc..1fac6d5 100644 --- a/tests/backtrace.c +++ b/tests/backtrace.c @@ -15,6 +15,10 @@ You should have received a copy of the GNU General Public License along with this program. If not, see <http://www.gnu.org/licenses/>. */ +/* Older systems (such as RHEL-5; fixed as binutils PR ld/12570 on 2011-06-20) + will fail this testcase as they do not provide CFI for the .plt section. + elfutils 'portable' patch/branch disables the .plt unwind test. */ + #include <config.h> #include <assert.h> #include <inttypes.h>