On Fri, 2015-09-18 at 11:25 -0700, Chih-Hung Hsieh wrote: > Now they should compile with clang. > > Used local variables are passed to new file scope functions > as constant parameters, or pointers, or embedded in a > 'state' structure. > > One simple function "report" is changed to a macro. > It triggers a gcc false positive -Werror=maybe-uninitialized, > so the local variables are explicitly initialized.
Pushed to master because they help you and they don't seem to make the code worse. These kind of patches are a bit of a pain though, they don't really improve the code IMHO and the moving around of code is a bit hard to review. Please keep these kind of patches as small as possible to help reviewers. Thanks, Mark
