If the FDE end <= start then it doesn't actually cover a valid code range.
Don't use and cache such FDEs (it will cause memory leaks if there is
another FDE that has the same start address and a valid code range).

Such FDEs have been seen in the backtrace.ppc.exec testfile.

Signed-off-by: Mark Wielaard <m...@redhat.com>
---
 libdw/ChangeLog | 5 +++++
 libdw/fde.c     | 7 +++++++
 2 files changed, 12 insertions(+)

diff --git a/libdw/ChangeLog b/libdw/ChangeLog
index 81eeae6..10df13b 100644
--- a/libdw/ChangeLog
+++ b/libdw/ChangeLog
@@ -1,5 +1,10 @@
 2015-12-01  Mark Wielaard  <m...@redhat.com>
 
+       * fde.c (intern_fde): Don't intern an fde that doesn't cover a
+       valid code range.
+
+2015-12-01  Mark Wielaard  <m...@redhat.com>
+
        * dwarf_end.c (dwarf_end): Call cu_free on fake_loc_cu if it exists.
 
 2015-10-19  Mark Wielaard  <m...@redhat.com>
diff --git a/libdw/fde.c b/libdw/fde.c
index c8475f3..2a59d3e 100644
--- a/libdw/fde.c
+++ b/libdw/fde.c
@@ -90,6 +90,13 @@ intern_fde (Dwarf_CFI *cache, const Dwarf_FDE *entry)
     }
   fde->end += fde->start;
 
+  /* Make sure the fde actually covers a real code range.  */
+  if (fde->start >= fde->end)
+    {
+      free (fde);
+      return (void *) -1;
+    }
+
   fde->cie = cie;
 
   if (cie->sized_augmentation_data)
-- 
2.5.0

Reply via email to