On 10/26/2016 03:24 AM, Mark Wielaard wrote: > The name used in the standard and other DWARF implementations for > Programming Language One, PL/I, is DW_LANG_PLI (not DW_LANG_PL1). > > Fix usage in dwarf_aggregate_size. > > Signed-off-by: Mark Wielaard <m...@redhat.com> > --- > NEWS | 5 +++++ > libdw/ChangeLog | 6 ++++++ > libdw/dwarf.h | 4 ++-- > libdw/dwarf_aggregate_size.c | 4 ++-- > 4 files changed, 15 insertions(+), 4 deletions(-) > > diff --git a/NEWS b/NEWS > index 599970b..6adb76f 100644 > --- a/NEWS > +++ b/NEWS > @@ -1,3 +1,8 @@ > +Version 0.168 > + > +libdw: dwarf.h corrected the DW_LANG_PLI constant name (was DW_LANG_PL1). > + Any existing sources using the old name will have to be updated. > +
That typo has been there since the dawn of elfutils.git, 2005-07-26 commit b08d5a8fb42f. It seems callous to break API here, even if it was wrong. Why not include a #define to preserve compatibility? > @@ -582,7 +582,7 @@ enum > DW_LANG_C99 = 0x000c, /* ISO C:1999 */ > DW_LANG_Ada95 = 0x000d, /* ISO Ada:1995 */ > DW_LANG_Fortran95 = 0x000e, /* ISO Fortran 95 */ > - DW_LANG_PL1 = 0x000f, /* ISO PL/1:1976 */ > + DW_LANG_PLI = 0x000f, /* ISO PL/1:1976 */ You should correct the comment too, "PL/I". _______________________________________________ elfutils-devel mailing list -- elfutils-devel@lists.fedorahosted.org To unsubscribe send an email to elfutils-devel-le...@lists.fedorahosted.org
