On 02/17/2017 10:46 AM, Mark Wielaard wrote: > On Thu, 2017-02-16 at 10:10 +0100, Ulf Hermann wrote: >> If it doesn't exist, provide a definition based on memcpy. > > Applied, but slightly reluctantly. I have no way to test this. And it > will evaluate the last argument (n) twice. Which seems to not matter in > the current calls in our codebase. But it might subtly break something > if someone forgets.
True. With other missing functions I tend to conditionally build the replacements into libeu.a as actual functions. That requires libeu.a to be linked into libdw.so, libelf.so, etc. I will create a followup patch that does the same with mempcpy. Ulf
