On 04/28/2017 12:23 AM, Mark Wielaard wrote: > On Thu, Apr 20, 2017 at 04:57:41PM +0200, Ulf Hermann wrote: >> Otherwise we skip the munmap() later. This leaks resources. > > Oops. Good find. Applied to master. > > When configured --with-valgrind the tests are run under valgrind > and memory leaks will fail the tests. But since this is mmap > valgrind won't report it. How did you find it?
On windows you cannot rename or unlink files if there are still open views on it (and the win32 view mechanism is how I implement mmap on windows). So, the test cases fail then because the directories are not empty. Ulf
