On Fri, May 10, 2019 at 11:48:32AM -0600, Tom Tromey wrote:
> >>>>> "Mark" == Mark Wielaard <m...@klomp.org> writes:
> 
> Mark> Decode DW_AT_descr_list blocks using the DW_DSC values.
> Mark> This requires knowing the signedness of the discriminant.
> Mark> Which means the attr_callback function needs access to the
> Mark> parent DIE. Pass the whole DIE path, plus the current level.
> Mark> That way the type of the discriminant can be looked up in
> Mark> the variant_part (parent) DIE of the variant DIE (which has
> Mark> the discr_list attribute).
> 
> Mark> Add a testcase using both signed and unsigned discriminants.
> 
> Mark> https://sourceware.org/bugzilla/show_bug.cgi?id=24509
> 
> Thank you for doing this.

I took this as "patch looks perfect" and pushed it to master.

Cheers,

Mark

Reply via email to