Hi -
> One suggestion, it be a good idea IMHO to initialize user_data to NULL.
> Just so a client knows whether or not it has been set or it is a random
> value.
Will document it as "undefined".
> > + debuginfod_end (client);
> > +
> > if (rc < 0)
> > {
> > fprintf(stderr, "Server query failed: %s\n", strerror(-rc));
> > @@ -137,9 +142,7 @@ main(int argc, char** argv)
> > }
> >
> > printf("%s\n", cache_name);
> > -
> > free (cache_name);
> > - debuginfod_end (client);
> >
> > return 0;
> > }
>
> Why is the debuginfo_end () call moved?
For valgrind cleanliness in the case of rc < 0 failure exit.
> > if DEBUGINFOD
> > notrans_dist_man8_MANS += debuginfod.8
> > -notrans_dist_man3_MANS += debuginfod_find_debuginfo.3
> > debuginfod_find_source.3 debuginfod_find_executable.3
> > debuginfod_set_progressfn.3
> > +notrans_dist_man3_MANS += debuginfod_begin.3
> > +notrans_dist_man3_MANS += debuginfod_end.3
> > +notrans_dist_man3_MANS += debuginfod_find_debuginfo.3
> > +notrans_dist_man3_MANS += debuginfod_find_executable.3
> > +notrans_dist_man3_MANS += debuginfod_find_source.3
> > +notrans_dist_man3_MANS += debuginfod_get_user_data.3
> > +notrans_dist_man3_MANS += debuginfod_set_progressfn.3
> > +notrans_dist_man3_MANS += debuginfod_set_user_data.3
> > notrans_dist_man1_MANS += debuginfod-find.1
> > endif
>
> What exactly is going on here?
> Did we forget some, so they didn't get distributed?
Yup.
- FChE
