On Mon, 2020-11-23 at 17:50 +0000, build...@builder.wildebeest.org
wrote:
> The Buildbot has detected a failed build on builder whole buildset
> while building elfutils.
> Full details are available at:
> https://builder.wildebeest.org/buildbot/#builders/1/builds/630
>
> Buildbot URL: https://builder.wildebeest.org/buildbot/
>
> Worker for this Build: centos-x86_64
>
> Build Reason: <unknown>
> Blamelist: Mark Wielaard <m...@klomp.org>
>
> BUILD FAILED: failed test (failure)
Interestingly only one buildbot worker found this issue, but I could
replicate it under valgrind locally. And indeed, valgrind is right. We
forgot to initialize the new handler_data errbuf field.
Fixed as attached.
Cheers,
Mark
From 6b82ac67d8a71c14f64fe4932ca7fe822ff75231 Mon Sep 17 00:00:00 2001
From: Mark Wielaard <m...@klomp.org>
Date: Mon, 23 Nov 2020 17:52:02 +0100
Subject: [PATCH] debuginfod-client: Initialize struct handle_data errbuf to
the empty string.
Signed-off-by: Mark Wielaard <m...@klomp.org>
---
debuginfod/ChangeLog | 5 +++++
debuginfod/debuginfod-client.c | 1 +
2 files changed, 6 insertions(+)
diff --git a/debuginfod/ChangeLog b/debuginfod/ChangeLog
index bd4dbf40..cd009fd2 100644
--- a/debuginfod/ChangeLog
+++ b/debuginfod/ChangeLog
@@ -1,3 +1,8 @@
+2020-11-23 Mark Wielaard <m...@klomp.org>
+
+ * debuginfod-client.c (debuginfod_query_server): Initialize
+ struct handle_data errbuf to the empty string.
+
2020-11-11 Mark Wielaard <m...@klomp.org>
* debuginfod-client.c (debuginfod_set_verbose_fd): New function.
diff --git a/debuginfod/debuginfod-client.c b/debuginfod/debuginfod-client.c
index 2bf1543a..a99f3c14 100644
--- a/debuginfod/debuginfod-client.c
+++ b/debuginfod/debuginfod-client.c
@@ -756,6 +756,7 @@ debuginfod_query_server (debuginfod_client *c,
{
data[i].handle = NULL;
data[i].fd = -1;
+ data[i].errbuf[0] = '\0';
}
char *strtok_saveptr;
--
2.18.4
