On Mon, Nov 30, 2020 at 08:00:00AM +0000, Dmitry V. Levin wrote: > According to GNU Automake documentation [1], $(EXEEXT) is the suffix > that should be used for executables, it is not applicable for shared > libraries. > > [1] https://www.gnu.org/software/automake/manual/html_node/EXEEXT.html
I think you are right and this patch is correct. This probably only affects non-posix or windows setups. Ulf (on CC now) was working on building on windows (although I think we never integrated all the patches for that). Maybe he has an opinion on this patch? Thanks, Mark > Signed-off-by: Dmitry V. Levin <l...@altlinux.org> > --- > debuginfod/ChangeLog | 4 ++++ > debuginfod/Makefile.am | 2 +- > libasm/ChangeLog | 4 ++++ > libasm/Makefile.am | 2 +- > libdw/ChangeLog | 4 ++++ > libdw/Makefile.am | 2 +- > libelf/ChangeLog | 4 ++++ > libelf/Makefile.am | 2 +- > 8 files changed, 20 insertions(+), 4 deletions(-) > > diff --git a/debuginfod/ChangeLog b/debuginfod/ChangeLog > index aaffac7c..3039371f 100644 > --- a/debuginfod/ChangeLog > +++ b/debuginfod/ChangeLog > @@ -1,3 +1,7 @@ > +2020-11-30 Dmitry V. Levin <l...@altlinux.org> > + > + * Makefile.am (libdebuginfod.so$(EXEEXT)): Drop $(EXEEXT) suffix. > + > 2020-11-25 Frank Ch. Eigler <f...@redhat.com> > > * debuginfod.cxx (step_ok_done): Correct typo in prom metric label. > diff --git a/debuginfod/Makefile.am b/debuginfod/Makefile.am > index 0af3b58c..352b4915 100644 > --- a/debuginfod/Makefile.am > +++ b/debuginfod/Makefile.am > @@ -100,7 +100,7 @@ libdebuginfod_so_LDLIBS = > else > libdebuginfod_so_LDLIBS = $(libcurl_LIBS) $(fts_LIBS) > endif > -libdebuginfod.so$(EXEEXT): $(srcdir)/libdebuginfod.map > $(libdebuginfod_so_LIBS) > +libdebuginfod.so: $(srcdir)/libdebuginfod.map $(libdebuginfod_so_LIBS) > $(AM_V_CCLD)$(LINK) $(dso_LDFLAGS) -o $@ \ > -Wl,--soname,$@.$(VERSION) \ > -Wl,--version-script,$<,--no-undefined \ > diff --git a/libasm/ChangeLog b/libasm/ChangeLog > index d7ab8c42..29c23bad 100644 > --- a/libasm/ChangeLog > +++ b/libasm/ChangeLog > @@ -1,3 +1,7 @@ > +2020-11-30 Dmitry V. Levin <l...@altlinux.org> > + > + * Makefile.am (libasm.so$(EXEEXT)): Drop $(EXEEXT) suffix. > + > 2020-10-29 Mark Wielaard <m...@klomp.org> > > * asm_align.c (__libasm_ensure_section_space): Use calloc, not > diff --git a/libasm/Makefile.am b/libasm/Makefile.am > index b2bff929..4b55d530 100644 > --- a/libasm/Makefile.am > +++ b/libasm/Makefile.am > @@ -63,7 +63,7 @@ endif > > libasm_so_LIBS = libasm_pic.a > libasm_so_SOURCES = > -libasm.so$(EXEEXT): $(srcdir)/libasm.map $(libasm_so_LIBS) $(libasm_so_DEPS) > +libasm.so: $(srcdir)/libasm.map $(libasm_so_LIBS) $(libasm_so_DEPS) > $(AM_V_CCLD)$(LINK) $(dso_LDFLAGS) -o $@ \ > -Wl,--soname,$@.$(VERSION) \ > -Wl,--version-script,$<,--no-undefined \ > diff --git a/libdw/ChangeLog b/libdw/ChangeLog > index 6f8ebea6..fbe2abc0 100644 > --- a/libdw/ChangeLog > +++ b/libdw/ChangeLog > @@ -1,3 +1,7 @@ > +2020-11-30 Dmitry V. Levin <l...@altlinux.org> > + > + * Makefile.am (libdw.so$(EXEEXT)): Drop $(EXEEXT) suffix. > + > 2020-11-01 Érico N. Rolim <erico....@gmail.com> > > * Makefile.am (libdw_so_LDLIBS): Add fts_LIBS. > diff --git a/libdw/Makefile.am b/libdw/Makefile.am > index 1dbb3d5e..f21ee6ae 100644 > --- a/libdw/Makefile.am > +++ b/libdw/Makefile.am > @@ -111,7 +111,7 @@ libdw_so_LIBS = ../libebl/libebl_pic.a > ../backends/libebl_backends_pic.a \ > libdw_so_DEPS = ../lib/libeu.a ../libelf/libelf.so > libdw_so_LDLIBS = $(libdw_so_DEPS) -ldl -lz $(argp_LDADD) $(fts_LIBS) > $(obstack_LIBS) $(zip_LIBS) -pthread > libdw_so_SOURCES = > -libdw.so$(EXEEXT): $(srcdir)/libdw.map $(libdw_so_LIBS) $(libdw_so_DEPS) > +libdw.so: $(srcdir)/libdw.map $(libdw_so_LIBS) $(libdw_so_DEPS) > $(AM_V_CCLD)$(LINK) $(dso_LDFLAGS) -o $@ \ > -Wl,--soname,$@.$(VERSION),--enable-new-dtags \ > -Wl,--version-script,$<,--no-undefined \ > diff --git a/libelf/ChangeLog b/libelf/ChangeLog > index d685872d..0a9e36a2 100644 > --- a/libelf/ChangeLog > +++ b/libelf/ChangeLog > @@ -1,3 +1,7 @@ > +2020-11-30 Dmitry V. Levin <l...@altlinux.org> > + > + * Makefile.am (libelf.so$(EXEEXT)): Drop $(EXEEXT) suffix. > + > 2020-11-06 Mark Wielaard <m...@klomp.org> > > * elf-knowledge.h (SH_ENTSIZE_HASH): Update comment. > diff --git a/libelf/Makefile.am b/libelf/Makefile.am > index d5d63f73..f8f2afeb 100644 > --- a/libelf/Makefile.am > +++ b/libelf/Makefile.am > @@ -113,7 +113,7 @@ endif > > libelf_so_LIBS = libelf_pic.a > libelf_so_SOURCES = > -libelf.so$(EXEEXT): $(srcdir)/libelf.map $(libelf_so_LIBS) $(libelf_so_DEPS) > +libelf.so: $(srcdir)/libelf.map $(libelf_so_LIBS) $(libelf_so_DEPS) > $(AM_V_CCLD)$(LINK) $(dso_LDFLAGS) -o $@ \ > -Wl,--soname,$@.$(VERSION) \ > -Wl,--version-script,$<,--no-undefined \ > -- > ldv
