Hi,

On Thu, 2021-07-08 at 09:12 -0400, Frank Ch. Eigler wrote:
> > If they are portions of the full fdcache shouldn't there be a check
> > in the code that the specified fdcache_prefetch_fds and
> > fdcache_prefetch_mbs aren't larger than fdcache_fds and fdcache_mbs? Or
> > maybe they should be given as percentages?
> 
> We've iterated on a couple of ways of representing & controlling this.
> The code makes the lru and prefetch caches separate, in that they have
> separate limits and separate metrics.  So there is no requirement for
> the prefetch one to be smaller than the other.

Aha, yes, that does look like how the code actually works. Lets make
sure the documentation matches that description (or at least remove the
phrase "portion of").

Cheers,

Mar

Reply via email to