Hi Adrian,
On Mon, 2021-08-30 at 18:43 +0300, Adrian Ratiu wrote:
> It is true that Clang does not support all gnu99 extensions [1],
> but not all of them are used in the codebase and over time there
> have been code cleanup efforts to improve Clang support.
>
> For example after commit 779c57ea ("readelf: Pull advance_pc()
> in file scope") there are no more nested function declarations
> and elfutils now builds fine with Clang.
>
> So in the interest of enabling Clang builds we remove the only
> remaining blocker: the configure checks for nested functions and
> variable length arrays which are also unused.
>
> Considering mixed decls and code is also part of c99 standard,
> the entire check becomes redundant and we can just replace
> AC_PROG_CC -> AC_PROG_CC_C99.
>
> [1] https://sourceware.org/bugzilla/show_bug.cgi?id=24964
> Signed-off-by: Adrian Ratiu <adrian.ra...@collabora.com>
Thanks for reworking the patch. Pushed.
Thanks,
Mark
