Hi Frank, On Thu, 2021-11-04 at 13:21 -0400, Frank Ch. Eigler via Elfutils-devel wrote: > commit 8ce18d0f8a5d7c00dc897f99751d575c8deeae82 (HEAD -> master) > Author: Frank Ch. Eigler <f...@redhat.com> > Date: Thu Nov 4 13:08:35 2021 -0400 > > PR28514: debuginfod: limit groom operation times > > For large databases and many stale files, it was possible to starve > rescan operations by numerous groom "nuke" (database delete ops). > Under the theory that including new data is at least as important as > aging old, we now impose a rough deadline on groom queries. > > In the process, we discovered that we were commiting some > undefined-behaviour sqlite ops (deleting rows while iterating), which > may explain some previous heisenbug occurrences. So the groom nuke > operations are split into decision & action phases, with associated > progress-tracking metrics. > > Testing the timeout facility requires hand-testing beyond the > testsuite (since it requires LARGE databases to show measurable query > times). So confirmed this part by hand.
Makes sense and looks good. Please push. Thanks, Mark
