Hi Ying,
On Tue, Mar 05, 2024 at 05:51:21PM +0800, Ying Huang wrote:
> From: Ying Huang <ying.hu...@oss.cipunited.com>
>
> Add abi_cfi, set_initial_registers_tid, unwind on mips.
Sorry for reviewing out of order. But this one looked easy enough.
The new abi_cfi, unwind and set_initial_registers_tid implementations
looks correct (even though I don't really known MIPS).
Pushed with the following ChangeLog entry added to the commit message.
* backends/Makefile.am (mips_SRCS): Add mips_initreg.c,
mips_cfi.c and mips_unwind.c.
* backends/mips_init.c (mips_init): HOOK abi_cfi, unwind and
set_initial_registers_tid. Set frame_nregs to 71.
* backends/mips_cfi.c: New file.
* backends/mips_initreg.c: Likewise.
* backends/mips_unwind.c: Likewise.
It would be helpful to see if you could come up with a testcase
similar to the ones in tests/run-backtrace-core-<arch>.sh with
tests/tests/backtrace.<arch>.{exec,core}.bz2 so it can be tested from
a non-MIPS setup (as opposed to the tests/run-backtrace-native.sh and
tests/run-backtrace-native-core.sh tests).
Thanks,
Mark
