Hi Serhei, On Tue, 2024-10-15 at 11:26 -0400, Serhei Makarov wrote: > Since we obtain diagnostics about unwind method, another logical place > to show them is in eu-stack. > > This requires an additional pseudo-unwind type DWFL_UNWOUND_INLINE to > clarify what happens with entries for inlined functions (which > eu-stacktrace does not display) based on the same Dwfl_Frame. > > * libdwfl/libdwfl.h (Dwfl_Unwound_Source): Add DWFL_UNWOUND_INLINE. > * libdwfl/dwfl_frame.c (dwfl_unwound_source_str): > Handle DWFL_UNWOUND_INLINE.
This part looks a little iffy IMHO. It feels like a layering violation. The meaning of DWFL_UNWOUND_INLINE is also different from the others. There is no worst/best ordering here. They are not connected to frames. Is there a way to move the printing of this into stack.c? For example make print_frame take a decorator argument that is a const char * instead of an unwound_source argument. Thanks, Mark
