On Thu, Oct 17, 2024 at 1:09 PM Serhei Makarov <ser...@serhei.io> wrote: > On Thu, Oct 17, 2024, at 12:18 PM, Aaron Merey wrote: > > I'm seeing eu-stacktrace built by default on x86 with no > > --enable-stacktrace given to configure. > Now I'm waffling back and forth on what to do. > > Mark wants to enable eu-stacktrace build on one of the buildbots. > The current behaviour (which does build eu-stacktrace > IF x86 asm/perf_regs.h AND /usr/include/sysprof-* are found) > would be fine for that. > Otherwise the ./configure command for that buildbot needs to be changed.
IMO let's disable by default for now since build issues/errors will be less likely. But if others prefer it enabled by default on x86 I'm not opposed to that. > > > LGTM. Can we change the eu-stacktrace usage text to mention that this > > is an experimental tool? And can "see README.eu-stacktrace in the > > source branch." include the URL? > Yes to both, fixing now. > > Could also change the NEWS to > > stacktrace: Experimental new tool that can process a stream of stack > samples from the Sysprof profiler and unwind them into call > chains. Enable on x86 with --enable-stacktrace. See > README.eu-stacktrace in the development branch for detailed > usage instructions: > > https://sourceware.org/cgit/elfutils/tree/README.eu-stacktrace?h=users/serhei/eu-stacktrace Good idea to include the URL there too. Thanks, Aaron
