Hi Michael,

On Tue, Nov 19, 2024 at 04:18:17AM +0000, Michael Pratt wrote:
> 
> >  This is because config/eu.am defines a default CLEANFILES. So those
> >  Makefile.am files should add to CLEANFILES with += instead of
> >  redefining CLEANFILES with =.
> 
> May I suggest to instead simply use
> "DISTCLEANFILES" for what is in eu.am?
> It's not being used anywhere else currently...

But aren't DISTCLEANFILES only remove for make distclean?  The *.gcno
*.gcda could be added to MOSTLYCLEANFILES since you would normally
want to regenerate them. I am not sure that would resolve your issue
though.

> If that's no good, I would then like to see a '+='
> in all the "*CLEANFILES" definitions in each level for each file
> so it's not confusing or looking like a possible mistake.

You mean even for MAINTAINERCLEANFILES and MOSTLYCLEANFILES? and even
for those (config/Makefile.am ./Makefile.am doc/Makefile.am) that
don't include eu.am (and also don't use CLEANFILES, except for the
top-level one)?

The "rule" now seems to be:
- When you use CLEANFILES you should now always use +=.
= MAINTAINERCLEANFILES and MOSTLYCLEANFILES uses =.

Is that "rule" really that confusing?

Cheers,

Mark

Reply via email to