Re: [PATCH] libdwfl: resolve all paths relative to sysroot

[Aaron Merey]

Hi Michal,

On Wed, Mar 19, 2025 at 2:33 PM Michal Sekletar <msekl...@redhat.com> wrote:
>
> Whenever possible, resolve all symlinks as if the sysroot path were a
> chroot environment. This prevents potential interactions with files from
> the host filesystem.
>
> Signed-off-by: Michal Sekletar <msekl...@redhat.com>
> ---
>  configure.ac                         | 17 +++++++++++++++++
>  libdwfl/dwfl_segment_report_module.c | 21 +++++++++++++++++++++
>  libdwfl/link_map.c                   | 27 ++++++++++++++++++++++++++-
>  3 files changed, 64 insertions(+), 1 deletion(-)

In addition to Dmitry's feedback, are you able to add a testcase to
tests/run-sysroot.sh?

To check if HAVE_OPENAT2_RESOLVE_IN_ROOT is defined you could use

    HAVE_OPENAT2=$(grep '^#define HAVE_OPENAT2_RESOLVE_IN_ROOT' \
        ${abs_builddir}/../config.h | awk '{print $3}')

    if [[ "$HAVE_OPENAT2" != 1 ]]; then <skip>

We have used this approach with other testcases that depend on a value
in config.h.

Thanks,
Aaron