Hi Mark,
On Thu, Dec 18, 2025 at 10:39 AM Mark Wielaard <[email protected]> wrote:
>
> Both run-compress-test and run-large-elf-file create really big
> files. Processing these under valgrind take a very long time. To
> encourage more testing under valgrind memcheck or helgrind disable
> valgrind for these two test so people don't have to wait 10 minutes
> for make check results.
>
> * tests/run-compress-test.sh: Unset VALGRIND_CMD.
> * tests/run-large-elf-file.sh: Likewise.
>
> Signed-off-by: Mark Wielaard <[email protected]>
It would be nice to have a configure option to control whether these
tests run under valgrind. But this is a niche enough case so that
manually commenting out `unset VALGRIND_CMD` is reasonable here.
Aaron
> ---
> tests/run-compress-test.sh | 3 +++
> tests/run-large-elf-file.sh | 3 +++
> 2 files changed, 6 insertions(+)
>
> diff --git a/tests/run-compress-test.sh b/tests/run-compress-test.sh
> index 2d4eebd61894..a57feadd7e53 100755
> --- a/tests/run-compress-test.sh
> +++ b/tests/run-compress-test.sh
> @@ -17,6 +17,9 @@
>
> . $srcdir/test-subr.sh
>
> +# This test just takes way too long under valgrind
> +unset VALGRIND_CMD
> +
> # uncompress -> gnucompress -> uncompress -> elfcompress -> uncompress
> testrun_elfcompress_file()
> {
> diff --git a/tests/run-large-elf-file.sh b/tests/run-large-elf-file.sh
> index 249ecd99cbfb..8044cc7b03e2 100755
> --- a/tests/run-large-elf-file.sh
> +++ b/tests/run-large-elf-file.sh
> @@ -18,6 +18,9 @@
>
> . $srcdir/test-subr.sh
>
> +# This test just takes way too long under valgrind
> +unset VALGRIND_CMD
> +
> # Only run on 64bit systems, 32bit systems don't support > 4GB
> # ELF files.
> long_bit=$(getconf LONG_BIT)
> --
> 2.52.0
>
