https://sourceware.org/bugzilla/show_bug.cgi?id=33974

--- Comment #2 from Serhei Makarov <serhei at serhei dot io> ---
(In reply to Sam James from comment #1)
> As discussed on IRC, the question is really what the best fix is. Should we
> build libdwfl_stacktrace at all on non-Linux?
I think that would be reasonable and the quickest solution. No objections to
disabling.

The configury could be modified later to re-enable the library for e.g. BSD
if/when the library is tested with a non-perf profiling method on BSD.

> (In reply to Sam James from comment #0)
> > and indeed the only definition is at libdwfl/linux-pid-attach.c.
> 
> Right now, it can't build on any non-Linux because the reference is
> unconditional in dwflst_sample_frame.c, yet it is only provided by a
> Linux-specific file.
Thanks for the clarification. In that case, other solutions are:
- move __libdwfl_set_initial_registers_thread outside of the #ifdef linux in
linux-pid-attach.c (will send a candidate patch for this)
- duplicate __libdwfl_set_initial_registers_thread to libdwfl_stacktrace
(removing the dependency)
- #ifdef the use in dwflst_sample_frame.c and have sample_set_initial_registers
fail on non-Linux (least preferable, better to just disable the library)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

Reply via email to