On Tue, Jul 14, 2026, at 7:43 PM, Aaron Merey wrote:
>
> Names are missing between the tags and the emails in this patch and
> the others in this series.
ack, fixing for the v3 patch submission
>> +# eu-stackprof currently only supports x86/ARM
>> +%ifarch %{all_x86} %{arm}
>
> AFAIK %{all_x86} is not an rpm macro. I think we want %{ix86},
> %{x86_64}, %{arm} and %{arm64} here.
ack, fixing. I found out "rpm --eval" is a quick way to test this out to be
sure without the full build process.
>> +AC_CHECK_HEADERS([linux/perf_event.h])
>
> We should check for $have_json too, or else use json conditionally in
> stackprof.cxx.
ack, fixing (the fix moves the check that sets $have_jsonc a bit earlier in the
file)
The comments for the other patches are fairly straightforward; applying the
fixes for those as well and currently testing on the trybot.
All the best,
Serhei
