On Mon, Oct 12, 2026 at 5:53 PM Magnus Lindholm <[email protected]> wrote:
> > +#if defined(_ASM_ALPHA_PERF_REGS_H)
>
> This should be _UAPI_ASM_ALPHA_PERF_REGS_H, matching your kernel
> header, the #endif comment needs updating too. Otherwise,
> PERF_FRAME_REGISTERS_ALPHA is zero.

Thanks for catching this, and for the detailed testing.

The guard as written matches the header after "make headers_install",
which strips the _UAPI prefix from include guards
(scripts/headers_install.sh), so it works against distro kernel
headers. I suspect you built against the uapi directory in the kernel
source tree, where the guard still has the _UAPI_ prefix. Switching
elfutils to _UAPI_ASM_ALPHA_PERF_REGS_H would break the installed
header case instead.

Most architectures (x86, arm64, riscv, loongarch, and others) avoid
this by using a plain _ASM_<ARCH>_PERF_REGS_H guard in the uapi header,
which reads the same before and after installation. That is also what
elfutils' existing x86 and arm64 checks rely on. The next revision of
the kernel series will do the same for alpha, so this patch can stay
as it is.

Reply via email to