Jonas Fonseca <[EMAIL PROTECTED]> writes:

>  - You indented the goto label in the first commit (e333fb37) and
>    normally labels should not be indented.

Oops.  I see that's in doc/hacking.txt too.  I guess I'll have to
configure Emacs to use a custom indentation style for ELinks code.

>  - I don't seem to remember the introduction of is_utf16_surrogate()
>    used in the second commit (be7526d0). Did you forgot to add
>    intl/charset.h to the file commit list?

I added is_utf16_surrogate in commit 38fe5b72 aka be7526d0~2,
"Define and use macros for handling UTF-16 surrogates."
I typically commit a whole tree, rather than individual files.

Attachment: pgplmyRpRFn3s.pgp
Description: PGP signature

_______________________________________________
elinks-dev mailing list
[email protected]
http://linuxfromscratch.org/mailman/listinfo/elinks-dev

Reply via email to