On Sun, Dec 03, 2006 at 07:47:42PM +0200, Kalle Olavi Niemitalo wrote: > Witold Filipczyk <[EMAIL PROTECTED]> writes: > > > If you apply this patch ELinks will read out documents. > > Simply press 'R' (r with SHIFT) and 'R' again to switch off. > > For speech the festival program is required. > > I hope it will be included in 0.12. > > Don't ask me to cleanup the code. Do it yourself! > > I am happy to see that you've been hacking ELinks. Perhaps > someone will review, test, and apply this patch, but it won't be > me because I'm currently more interested in fixing the bugs that > block 0.12 than in adding new features. > > This code appears to be better than a screen reader, because it > reads complete lines regardless of how wide the window is; and > better than just piping the formatted document to an external > process, because the user can choose a starting position and > easily stop the previous output. Is that correct? > > Is there a risk that if the festival process is somehow blocked, > then ELinks will also be blocked trying to write to the pipe?
Yes. It is possible, but set_nonblocking somewhere should fix it. > > The code uses dup2 and execl. Does this cause problems on > non-POSIX ports? I didn't think about it. The code should be enclosed by IF_HAVE_FORK or something like that. BTW, could you look at SMB prototocol, bug 844? _______________________________________________ elinks-dev mailing list [email protected] http://linuxfromscratch.org/mailman/listinfo/elinks-dev
