In do_smb, we have:

                add_to_string(&string, "smb://");
                add_to_string(&string, auth->user);
                add_char_to_string(&string, ':');
                add_to_string(&string, auth->password);
                add_char_to_string(&string, '@');
                add_to_string(&string, uri_string);
                url = string.source;

So if there is already '@' or '/' as part of auth->password, then
the result seems to become ambiguous.
- Is it possible to have "@" or '/' in auth->password, or would
  they have already been converted to "%40" and "%2F" before
  do_smb runs?
- If there are multiple @ signs, can libsmbclient parse the URL
  correctly anyway?
- Should encode_uri_string be used here instead of add_to_string?

Attachment: pgpH5u5tTLGu7.pgp
Description: PGP signature

_______________________________________________
elinks-dev mailing list
[email protected]
http://linuxfromscratch.org/mailman/listinfo/elinks-dev

Reply via email to