Kalle Olavi Niemitalo <[EMAIL PROTECTED]> wrote Sun, Feb 24, 2008:
> Commit d4cec950ecadb0c19206f28b0bf9c6d8992bc1e7 added
> to src/protocol/http/http.c:
>
> #if !(defined(CONFIG_GZIP) || defined(CONFIG_BZIP2))
> #define COMP_NOTE "\nNote that this ELinks version has been compiled without
> compression\n" \
> "support anyway. This option will have no effect.\n"
> #else
> #define COMP_NOTE
> #endif
> INIT_OPT_BOOL("protocol.http", N_("Enable on-the-fly compression
> (experimental)"),
> "compression", 0, 1,
> N_("If enabled, the capability to receive compressed content
> (gzip and/or\n"
> "bzip2) is announced to the server, which usually sends the
> reply\n"
> "compressed, thus saving some bandwidth at slight CPU
> expense.\n"
> "HOWEVER, please note that the ELinks implementation is
> unfortunately very\n"
> "buggy and you may see incomplete pages, pages with garbage
> instead of\n"
> "content, etc.!" COMP_NOTE)),
Wouldn't it have been easier to just leave out the option completely?
> Anyway, instead of putting the both versions of the whole string
> inside #if, I'd like to revert this commit altogether.
> With Witek's latest changes, compression is not so experimental
> any more, I think. Can you find any site where it still fails?
I haven't tested it personally, but I think it is the right thing to do.
--
Jonas Fonseca
_______________________________________________
elinks-dev mailing list
[email protected]
http://linuxfromscratch.org/mailman/listinfo/elinks-dev
