Guido Amoruso wrote: > Hi guys, > > in the last commit of the branch > lp:~guidonte/elisa/upicek_empty_container you can see the way I'd like > to refactor the mechanism to alert for "empty container". There are two > sample implementation, one for the Favorites and one for the Filesystem > controllers. > > I'd like to hear from you - Florian and Olivier, specially! - what you > think about my idea. > > Thanks, > guido
The proposal looks good to me, I did not do a thorough review of the code, nor did I actually run it, but the principle is ok. One remark: the name "nothing_to_display_widget" really sucks, I think your refactoring is a good opportunity to get rid of it. Thanks for your work on it. Olivier
