Kristian Lippert a écrit : > Hi > I want to use Elisa with my Bang & Olufsen Beo4 remote. > So I created a LIRC daemon plugin and some lirc and Elisa mappings. > The problem was that vol_up and vol_down did not work at all. So I fixed > it in my Elisa 0.5.25 code. > But now the code is gone with Elisa 0.5.26 (I do have a backup :-). > What should I do to make it a permanent change in Elisa?
With Elisa 0.5.26 we released updates to the pigment and poblesec plugins, so if your changes were there, although not lost, they will be superseded by the new versions. The best way to make it a permanent change in Elisa is to submit your code so we can review it and merge it in mainstream Elisa. Instructions to submit your changes can be found at http://elisa.fluendo.com/participate/. > The next question is now: I also discovered that when the player did not > have focus it would not receive the vol_up and vol_down, so I fixed that > too with some delegation (with a dirty hack, but I only did as others > had done before me :-) > Should that go into the code base too? If it is a dirty hack, no. But we can maybe find an elegant way to solve the issue, with inspiration from your hack. If it doesn't exist yet, start by creating a bug report for the issue, and attach your patch there. > In the player when comming from the remote the "up" and "down" I would > like to be next-track and prev-track and not vol-up and vol_down. It is > easy to maintain the usual keyboard-arrow-up and down at the same time. > Will that be possible too? Having two different behaviours for the same keys on different input devices seems counter-intuitive to me, but I'm no ergonomics expert so your suggestion may make sense. Just so we don't lose the idea, could you file a bug report as a feature request? > Best Regards, > Kristian Cheers, Olivier
