I'm nervous about existing inspect abuse as a hacky to_string. I could see someone using it and feeding the result into a hashing function and this change would break such an implementation.
Being able to turn it off is probably sufficient. Would it make sense to turn it off at a global level? On Mon, Jun 20, 2016, 9:38 AM José Valim <[email protected]> wrote: > I like this proposal. I would even pick it is a default with an option to > turn it off. Does anyone else have feedback? :) > > > > *José Valim* > www.plataformatec.com.br > Skype: jv.ptec > Founder and Director of R&D > > On Tue, Jun 14, 2016 at 11:22 PM, Wojtek Mach <[email protected]> > wrote: > >> Hello everyone, >> >> It's very convenient to write down integer literals as e.g. 10_000_000 - >> much easier for humans to read. >> >> I was recently debugging some performance issues and I was working with >> this data in iex: >> >> [memory: 173978912, message_queue_len: 0, heap_size: 12834421, >> total_heap_size: 21747214, >> garbage_collection: [min_bin_vheap_size: 46422, min_heap_size: 233, >> fullsweep_after: 65535, minor_gcs: 2]] >> >> This data would be *much* more readable to me with digit separators: >> >> [memory: 173_978_912, message_queue_len: 0, heap_size: 12_834_421, >> total_heap_size: 21_747_214, >> garbage_collection: [min_bin_vheap_size: 46_422, min_heap_size: 233, >> fullsweep_after: 65_535, minor_gcs: 2]] >> >> It probably shouldn't be the default behavior for inspect/2, so I think >> this could only happen with one of: [pretty: true] , [pretty: :decimal]or >> perhaps something like [pretty_decimal: true]. >> >> Regards, >> Wojtek >> >> -- >> You received this message because you are subscribed to the Google Groups >> "elixir-lang-core" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/elixir-lang-core/93f9f36d-f3f3-41f7-856b-c1422cd40026%40googlegroups.com >> <https://groups.google.com/d/msgid/elixir-lang-core/93f9f36d-f3f3-41f7-856b-c1422cd40026%40googlegroups.com?utm_medium=email&utm_source=footer> >> . >> For more options, visit https://groups.google.com/d/optout. >> > > -- > You received this message because you are subscribed to the Google Groups > "elixir-lang-core" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/elixir-lang-core/CAGnRm4%2Bd%2BsvetpUs_mC-VEnH3y9J6nFyXyuDQ1ixW6Wnu7zV%3DA%40mail.gmail.com > <https://groups.google.com/d/msgid/elixir-lang-core/CAGnRm4%2Bd%2BsvetpUs_mC-VEnH3y9J6nFyXyuDQ1ixW6Wnu7zV%3DA%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "elixir-lang-core" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/elixir-lang-core/CAOMhEnwVRt-Xj2ajecHcdDPcZbCt5FU50v1Ng6gHH%2BAsD%2BjJag%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
