On Monday, October 31, 2016 at 8:39:31 AM UTC-7, OvermindDL1 wrote:
>
> /me coughs:
> {Credo.Check.Readability.MaxLineLength, priority: :low,
> max_length: 120},
>
On Sun, Oct 30, 2016 at 8:21 PM, Chris Keele <[email protected]> wrote:
> I've figured out how to customize and filter it now, so I'm satisfied with
> a wider margin.
>
One cool thing I never realized about credo is that you can reapply checks,
so I've set it up for now as:
{Credo.Check.Readability.MaxLineLength, priority: :low, max_length: 90},
{Credo.Check.Readability.MaxLineLength, priority: :high, max_length: 120},
On a side note, I use fence blocks in my doctests without issue? Just have
> to have a blank line before/after the code itself.
>
As it turns out, the issue I was experiencing was that you have to have a
blank line in-between the last example and the fence closing, because
without it ExUnit interprets the ``` as part of the tests.
You can see in my PR <https://github.com/elixir-lang/elixir/pull/5389/files>
that by making ExUnit aware of fences as test terminators, it allows
tighter whitespace around tests, and correctly fails if there are actual
issues with the last test itself rather than the lack of a newline.
More importantly, it gives ExUnit and ExDoc feature parity, and
additionally raises compile errors on improperly formatted fenced code
blocks that would violate the CommonMark spec and cause issues within ExDoc
output.
--
You received this message because you are subscribed to the Google Groups
"elixir-lang-core" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/elixir-lang-core/61615b23-06aa-4654-8228-8b190ecdcd90%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
