Yes being part of the metadata would be great. Need to look around/research and see what other people have done. Just not losing the data would be great.
> On Sep 17, 2018, at 12:10, José Valim <[email protected]> wrote: > > I don't think we ever stored them in meta. But even if we did, we would > probably have done it in the formatter, and we should likely move it > somewhere public. > > > > José Valim > www.plataformatec.com.br > Skype: jv.ptec > Founder and Director of R&D > >> On Mon, Sep 17, 2018 at 8:37 PM, Louis Pilfold <[email protected]> >> wrote: >> Hey >> >> I'm a little out of touch with this area, but isn't this what we previously >> did? I remember comments being stored in meta during the creation of the >> formatter. Or did I make that up? >> >> Cheers, >> Louis >> >>> On Mon, 17 Sep 2018 at 19:17 José Valim <[email protected]> >>> wrote: >>> I like the metadata idea a lot, thanks. We still need someone to send a >>> detailed proposal, including what will happen with inline comments, >>> comments inside blocks and comments as the last line of a block with no >>> expression afterwards. >>> >>> We also need a discussion on what will happen with nodes that do not have a >>> metadata entry. Wrapping those in a block is likely enough (but it will >>> break semantics, for example, in keywords lists). So it would need to be an >>> opt-in feature only. >>> >>> Once all the details are ironed out, then somebody can go ahead and fully >>> implement it. :) >>> -- >>> >>> >>> José Valim >>> www.plataformatec.com.br >>> Skype: jv.ptec >>> Founder and Director of R&D >>> -- >>> You received this message because you are subscribed to the Google Groups >>> "elixir-lang-core" group. >>> To unsubscribe from this group and stop receiving emails from it, send an >>> email to [email protected]. >>> To view this discussion on the web visit >>> https://groups.google.com/d/msgid/elixir-lang-core/CAGnRm4J4%2BcTqcXH_ESJL2_o7rv5OJxkf_yJDpVAH%3DCjH2mmO7w%40mail.gmail.com. >>> For more options, visit https://groups.google.com/d/optout. >> >> -- >> You received this message because you are subscribed to the Google Groups >> "elixir-lang-core" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/elixir-lang-core/CABu8xFAk6UQJbbMcD2xkwJFLPM%3DbASSnOqL6ihSdUQEMpuKNGg%40mail.gmail.com. >> For more options, visit https://groups.google.com/d/optout. > > -- > You received this message because you are subscribed to the Google Groups > "elixir-lang-core" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/elixir-lang-core/CAGnRm4LmVcoPq7fRkJY5ErJ4N93Bd8-9erEByNETt%2BLN5DZuYA%40mail.gmail.com. > For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups "elixir-lang-core" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/elixir-lang-core/A72C2016-A449-43E5-8B85-6B5C37FD1818%40gmail.com. For more options, visit https://groups.google.com/d/optout.
