The syntax that José proposed is common to other command line tools so I vote
for it.
I have wanted to do more than one file. As a user I’m not at all concerned with
the verbosity of the parsed version. If it isn’t a big impact on performance.
Some setups can be large, and starting of applications. I’d rather save the
time there and not have to chain command line calls. Chaining command line
calls also has the added issue of one command has a failure and the rest don’t
run.
Amos King
Binary Noggin
> On Jan 9, 2019, at 04:46, Sven Gehring <cbr...@gmail.com> wrote:
>
> I'd personally prefer the syntax proposed by José.
>
> Also, I would argue that allowing for multiple files introduces quite a bit
> of unnecessary complexity.
>
> I never had the need to run only specific tests in multiple files but I think
> if it is really necessary for
> someone, you can always still chain the commands (ie. mix test ... && mix
> test ...) which is not ideal
> because you do the setup/teardown twice but I think it would work to cover
> that edge case
>
> Sven
>
>> On Wed, 9 Jan 2019 at 11:18 José Valim <jose.va...@plataformatec.com.br>
>> wrote:
>> *Stream of thoughts below.*
>>
>> Can you use only instead?
>>
>> mix test --only line:74 --only line:92
>> test/potion_web/plugs/persist_request_plug_test.exs
>>
>> My only concern with your feature proposal is that it may lead to wanting to
>> run multiple tests across multiple files and that's a trickier problem. One
>> option would be change our line filter to be something like file+line. In a
>> way that:
>>
>> mix test test/potion_web/plugs/persist_request_plug_test.exs:92
>>
>> becomes:
>>
>> Including tags: [location:
>> {"test/potion_web/plugs/persist_request_plug_test.exs", 92}]
>>
>> but that's quite more verbose. Thoughts?
>>
>> However, if we decide we don't need to support multiple files, then I would
>> do:
>>
>> mix test test/potion_web/plugs/persist_request_plug_test.exs:92:94:102
>>
>> José Valim
>> www.plataformatec.com.br
>> Skype: jv.ptec
>> Founder and Director of R&D
>>
>>
>>> On Wed, Jan 9, 2019 at 11:00 AM Devon Estes <devon.c.es...@gmail.com> wrote:
>>> Currently, if I want to run only a single test by line number, I can easily
>>> do:
>>>
>>> mix test test/potion_web/plugs/persist_request_plug_test.exs:92
>>>
>>> This is parsed in ExUnit as:
>>>
>>> Including tags: [line: "92"]
>>> Excluding tags: [:test]
>>>
>>> But if I want to only run two tests in a file, I need to do:
>>>
>>> mix test --include line:74 --include line:92 --exclude test
>>> test/potion_web/plugs/persist_request_plug_test.exs
>>>
>>> I'm proposing a shorthand for this, along the lines of what we already have
>>> for filtering by line number:
>>>
>>> mix test test/potion_web/plugs/persist_request_plug_test.exs:[74, 92]
>>>
>>> Which, when parsed, gives us
>>>
>>> Including tags: [line: "74", line: "92"]
>>> Excluding tags: [:test]
>>>
>>> I'd be happy to implement this if y'all think it's a good idea
>>> --
>>> You received this message because you are subscribed to the Google Groups
>>> "elixir-lang-core" group.
>>> To unsubscribe from this group and stop receiving emails from it, send an
>>> email to elixir-lang-core+unsubscr...@googlegroups.com.
>>> To view this discussion on the web visit
>>> https://groups.google.com/d/msgid/elixir-lang-core/e04f0e77-3c37-4f0f-b4a0-664e8ce74cea%40googlegroups.com.
>>> For more options, visit https://groups.google.com/d/optout.
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "elixir-lang-core" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to elixir-lang-core+unsubscr...@googlegroups.com.
>> To view this discussion on the web visit
>> https://groups.google.com/d/msgid/elixir-lang-core/CAGnRm4JvEOHo565x74FbfCdW6piNwxqwBjToy8kKAN_SQg0ZTQ%40mail.gmail.com.
>> For more options, visit https://groups.google.com/d/optout.
>
> --
> You received this message because you are subscribed to the Google Groups
> "elixir-lang-core" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to elixir-lang-core+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/elixir-lang-core/CAFuVuxyybff9FqXgy3vgmHxayMNnPCboN99hea_0RQeTnahSFg%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google Groups
"elixir-lang-core" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to elixir-lang-core+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/elixir-lang-core/534531EE-D413-4C91-90A3-B105690C3838%40binarynoggin.com.
For more options, visit https://groups.google.com/d/optout.
