My biggest concern about this feature is that we discourage testing of private functions and adding this feature only to encourage it would be directly against the practices we want to promote.
Given there are other ways to achieve this feature, for example, having a "use ExportAll", I would prefer for developers to achieve this in one of the many ways than directly make it part of the language. > There also seems to be a bug currently that when you pass ERL_COMPILER_OPTIONS="export_all" from the command line it tags it as an option in the compiled beam, but it did not actually export_all modules. This is a bug though. It will be fixed in master, thank you. *José Valim* www.plataformatec.com.br Skype: jv.ptec Founder and Director of R&D On Mon, Apr 1, 2019 at 8:27 AM Matthew O'Gorman <m...@rldn.net> wrote: > I submitted this pr https://github.com/elixir-lang/elixir/pull/8925 and > jose asked that I come to list, to talk about it. > > My motivations for doing so is to expose export_all compiler option at mix > level. My use case exposing private functions to unit tests for smaller > more directed tests, as well as writing tests for some private functions. > I also want to allow my dev environment to access private function for > easier debugging and experimentation. > > I realized that others have solved this issue other ways, putting > @compile flags everywhere wrapped in an if Mix.env == :test block, or > other macros and libraries doing the same thing. > > I personally think it makes sense to expose the builtin erlang method for > doing this instead of those other techniques, especially as when I googled > around it seems people think what I am doing is already possible even > though it is not. > > There also seems to be a bug currently that when you pass > ERL_COMPILER_OPTIONS="export_all" from the command line it tags it as an > option in the compiled beam, but it did not actually export_all modules. > > Mog > > -- > You received this message because you are subscribed to the Google Groups > "elixir-lang-core" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to elixir-lang-core+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/elixir-lang-core/aa4e74c3-d1d6-416a-9169-77037d056db4%40googlegroups.com > <https://groups.google.com/d/msgid/elixir-lang-core/aa4e74c3-d1d6-416a-9169-77037d056db4%40googlegroups.com?utm_medium=email&utm_source=footer> > . > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "elixir-lang-core" group. To unsubscribe from this group and stop receiving emails from it, send an email to elixir-lang-core+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/elixir-lang-core/CAGnRm4%2BgyS%3DX3-mpQiB2Kb6qyZ0bmzgTA-Hj6k5Lpe99EzL8yA%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.