Thank you José!

For context closure we resolved this in 
https://github.com/elixir-lang/elixir/pull/11457

On Tuesday, December 7, 2021 at 12:55:39 PM UTC-5 José Valim wrote:

> I like the additional input on why it failed, a PR is definitely welcome.
>
> On Tue, Dec 7, 2021 at 5:03 PM Aaron Gunderson <agund...@skylla.tech> 
> wrote:
>
>> We are running elixir:latest in CI and hit this ambiguous problem with 
>> the new change to coverage thresholds reporting an error:
>>
>> Changelog notes:
>> [mix test] Exit with a status of 3 when coverage falls below threshold
>>
>> Reading CI it was unclear what was failing as the only indication of an 
>> error is the red on the coverage percentage which obviously isn't visible 
>> in this CI configuration. I think it would be much better to have an 
>> explicit failure line like:
>>
>> ```
>> -----------|--------------------------
>>     63.13% | Total
>>     
>> Coverage failed, threshold not met:
>>   Coverage:  63.13%
>>   Threshold: 75%
>>   
>> See https://hexdocs.pm/mix/1.13.0/Mix.Tasks.Test.html#module-coverage
>>
>> Generated HTML coverage results in "cover" directory
>> ```
>>
>> Thoughts?
>>
>> -- 
>> You received this message because you are subscribed to the Google Groups 
>> "elixir-lang-core" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to elixir-lang-co...@googlegroups.com.
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/elixir-lang-core/2c1ce6cc-c0bd-4f44-a5ee-05d0f0c9c880n%40googlegroups.com
>>  
>> <https://groups.google.com/d/msgid/elixir-lang-core/2c1ce6cc-c0bd-4f44-a5ee-05d0f0c9c880n%40googlegroups.com?utm_medium=email&utm_source=footer>
>> .
>>
>

-- 
You received this message because you are subscribed to the Google Groups 
"elixir-lang-core" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to elixir-lang-core+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/elixir-lang-core/f46abc02-d53f-4e2c-afb5-4f52e680a416n%40googlegroups.com.

Reply via email to