While rather uncommon to delete things by setting to nil, I think parity with
put_env/1 is worth it. I think it is fine to have put_env and delete_env.
delete_env matches Application.delete_env, {Map,Keyword}.delete, etc, so I’d
definitely keep it.
> On 18 Sep 2023, at 19:38, Michal Śledź <michal.sl...@swmansion.com> wrote:
>
> I did the change and when updating tests I noticed there is already
> `delete_env` and now I am no longer sure about modyfing put_env. If we do it,
> we should probably deprecate delete_env?
>
>
>
> poniedziałek, 18 września 2023 o 18:54:12 UTC+2 José Valim napisał(a):
>> Sounds good to me. PR welcome!
>>
>> On Mon, Sep 18, 2023 at 6:41 PM Michal Śledź <michal...@swmansion.com <>>
>> wrote:
>>> System.put_env/1 erases given key when a value is nil.
>>>
>>> The proposal is to make System.put_env/2 symmetric with the
>>> System.put_env/1 and also erase a key on the nil value.
>>>
>>> The spec would change from:
>>>
>>> @spec put_env(binary(), binary()) :: :ok
>>>
>>> to:
>>>
>>> @spec put_env(binary(), binary() | nil) :: :ok
>>>
>>
>>> --
>>> You received this message because you are subscribed to the Google Groups
>>> "elixir-lang-core" group.
>>> To unsubscribe from this group and stop receiving emails from it, send an
>>> email to elixir-lang-co...@googlegroups.com <>.
>>> To view this discussion on the web visit
>>> https://groups.google.com/d/msgid/elixir-lang-core/0cc7caf8-f152-4476-9472-454c5c7e2f07n%40googlegroups.com
>>>
>>> <https://groups.google.com/d/msgid/elixir-lang-core/0cc7caf8-f152-4476-9472-454c5c7e2f07n%40googlegroups.com?utm_medium=email&utm_source=footer>.
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "elixir-lang-core" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to elixir-lang-core+unsubscr...@googlegroups.com
> <mailto:elixir-lang-core+unsubscr...@googlegroups.com>.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/elixir-lang-core/a976c524-aed2-4cb0-9b54-78a036e25ca0n%40googlegroups.com
>
> <https://groups.google.com/d/msgid/elixir-lang-core/a976c524-aed2-4cb0-9b54-78a036e25ca0n%40googlegroups.com?utm_medium=email&utm_source=footer>.
--
You received this message because you are subscribed to the Google Groups
"elixir-lang-core" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to elixir-lang-core+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/elixir-lang-core/03588C14-C8FA-478D-B233-FF1B9C64F0BD%40wojtekmach.pl.
