Hi Peter and thanks for your reply. I am mainly seeking for best practise approaches to my code quality after I make a project so that I may learn on it for the next one. I realise it's tricky for this particular one, because there's not much to the app. I managed to put your suggestion to use in updated version of the code, where I have refactored a lot of the view out into functions: https://github.com/alanbuchanan/elm-sandbox/blob/20005ae61e8577b91c717fdcdc5f9da6c351bc9b/GithubUserLookup.elm
On Sunday, 4 September 2016 18:56:37 UTC+1, Peter Damoc wrote: > > The code looks OK. > > I can tell you how to tidy up the code or how to optimize some other > things BUT what is exactly the issue that you are facing here? > Where is the difficulty? > What have you tried and it didn't worked as you expected? > > For example, if you don't want the styles to bother you when looking at > the view, you can extract the list of styles in a value. > > containerStyles : List (String, String) > containerStyles = > [ ( "display", "flex" ) > , ( "justify-content", "center" ) > , ( "align-items", "center" ) > , ( "flex-direction", "column" ) > ] > > Have you tried something like this and encountered some difficulties? > > > > > On Sun, Sep 4, 2016 at 8:39 PM, Rory Smith <[email protected] <javascript:> > > wrote: > >> As outlined here: >> http://codereview.stackexchange.com/questions/140481/github-user-lookup >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Elm Discuss" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected] <javascript:>. >> For more options, visit https://groups.google.com/d/optout. >> > > > > -- > There is NO FATE, we are the creators. > blog: http://damoc.ro/ > -- You received this message because you are subscribed to the Google Groups "Elm Discuss" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
